bug: NativeFunctionTypeDeclarationCasingFixer - do not require T_STRING present in code#6812
Merged
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom Mar 11, 2023
werlos:fix_NativeFunctionTypeDeclarationCasingFixer
Merged
bug: NativeFunctionTypeDeclarationCasingFixer - do not require T_STRING present in code#6812keradus merged 2 commits intoPHP-CS-Fixer:masterfrom werlos:fix_NativeFunctionTypeDeclarationCasingFixer
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
werlos:fix_NativeFunctionTypeDeclarationCasingFixer
Conversation
Pull Request Test Coverage Report for Build 4378332883
💛 - Coveralls |
Wirone
requested changes
Mar 10, 2023
Member
Wirone
left a comment
There was a problem hiding this comment.
Suggested changes cover scenario for arrow function that IMHO should be fixed too, but it isn't:
Code build on input code must match expected code.
Failed asserting that two strings are identical.
Expected :'<?php return fn (callable $c): int => 1;'
Actual :'<?php return fn (CALLABLE $c): INT => 1;'
Wirone
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.