Skip to content

DX: refactor PHPUnit fixers adding class-level annotation to use shared code#6756

Merged
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:refactor_php_unit_fixers_adding_class_annotation
Mar 22, 2023
Merged

DX: refactor PHPUnit fixers adding class-level annotation to use shared code#6756
keradus merged 1 commit intoPHP-CS-Fixer:masterfrom
werlos:refactor_php_unit_fixers_adding_class_annotation

Conversation

@kubawerlos
Copy link
Copy Markdown
Member

@kubawerlos kubawerlos commented Jan 21, 2023

This is a pure refactor, so it keeps 3 inconsistencies between the fixers:

        bool $addWithEmptyLineBeforePhpdoc,
        bool $addWithEmptyLineBeforeAnnotation,
        bool $addInSingleLinePhpdoc,

that could be changed in separate PR - separate because then it won't be refactor, but enhancement/improvement.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4461806511

  • 68 of 68 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.994%
Totals Coverage Status
Change from base Build 4461007069: 0.03%
Covered Lines: 22671
Relevant Lines: 24379
💛 - Coveralls

@Wirone Wirone added the RTM Ready To Merge label Mar 20, 2023
@keradus keradus merged commit dbfd4f3 into PHP-CS-Fixer:master Mar 22, 2023
@Wirone Wirone removed the RTM Ready To Merge label Mar 22, 2023
@kubawerlos kubawerlos deleted the refactor_php_unit_fixers_adding_class_annotation branch March 22, 2023 16:19
@kubawerlos kubawerlos mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wirone Wirone Wirone approved these changes

Assignees

No one assigned

Labels

kind/refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kubawerlos @coveralls @Wirone @keradus