feature: [PHP8.2] Support for readonly classes#6745
Merged
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom Feb 28, 2023
Merged
feature: [PHP8.2] Support for readonly classes#6745keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
keradus merged 5 commits intoPHP-CS-Fixer:masterfrom
Conversation
Member
|
is it easily possible to split the commit into what Space' provided and new changes separately? now, you kind of ask for review everything from scratch :( |
Member
Author
|
@keradus this is only patch applied from @SpacePossum's commit taken from here, no new changes. I wanted to check if it passes on newest |
Pull Request Test Coverage Report for Build 4283243810
💛 - Coveralls |
This was referenced Jan 9, 2023
kubawerlos
requested changes
Jan 21, 2023
Member
Author
|
FYI: Sorry for lack of response, I did not have time lately, but I'll try to look at it later today 🙂 |
These are changes initially proposed by SpacePossum in PHP-CS-Fixer#6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.
1e99e74 to
a59ea7b
Compare
I wanted to commit suggestion from Github, but it would fail in tests (expected output had to be changed too).
352ad95 to
12daa46
Compare
kubawerlos
approved these changes
Feb 27, 2023
Member
|
big thanks @SpacePossum and @Wirone , as well as @kubawerlos for nice review! |
Contributor
|
nice one @Wirone 👍 🎉 |
Member
Author
|
To be fair, it's all thanks to @SpacePossum - I only did maintenance work to refresh the branch and fixed little issues to align the code with current CS rules. Anyway, happy that |
livsi
pushed a commit
to livsi/easy-tasks
that referenced
this pull request
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6604.
These are changes initially proposed by SpacePossum in #6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.