changes needed for ci.common varProcessing#1843
Merged
cherylking merged 6 commits intoOpenLiberty:mainfrom Nov 13, 2024
Merged
Conversation
…maven integration tests Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
requested changes
Nov 8, 2024
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
…nd reload serverconfigdocument Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
cherylking
reviewed
Nov 12, 2024
Member
cherylking
left a comment
There was a problem hiding this comment.
Looks good. But I will hold off on approval until the common PR is merged and the changes to yaml file are removed.
Signed-off-by: Arun Venmany <Arun.Kumar.V.N@ibm.com>
Member
|
Requires OpenLiberty/ci.common#462 |
cherylking
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.