Handle Java source versions other than 8 for compile-jsp#1813
Merged
cherylking merged 5 commits intoOpenLiberty:mainfrom May 6, 2024
Merged
Handle Java source versions other than 8 for compile-jsp#1813cherylking merged 5 commits intoOpenLiberty:mainfrom
cherylking merged 5 commits intoOpenLiberty:mainfrom
Conversation
89dc5f6 to
a5ab4ac
Compare
a5ab4ac to
1167f4b
Compare
Member
Author
|
Doc for reference - versions older than |
mattbsox
approved these changes
May 6, 2024
NottyCode
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1812
setSourcefor versions later than Java 8.This PR does the minimum necessary to fix the issue:
releaseparameter forsetSourceif it is specified in the projectmaven-compiler-pluginconfigsourceparameter forsetSourceif it is specified in the projectmaven-compiler-pluginconfigmaven.compiler.releaseMaven property ormaven.compiler.sourceMaven property if specified.java.specification.versionjavaSourceLevelif the version of Liberty is24.0.0.1or later and the value used forsourceis Java 8 or later. Otherwise, it will still usejdkSourceLevelfor older versions of Liberty.