Skip to content

Add PHP 8.5 support#270

Merged
Ocramius merged 3 commits intoOcramius:2.11.xfrom
sitrunlab:add-php85
Nov 27, 2025
Merged

Add PHP 8.5 support#270
Ocramius merged 3 commits intoOcramius:2.11.xfrom
sitrunlab:add-php85

Conversation

@samsonasik
Copy link
Copy Markdown
Contributor

No description provided.

@Ocramius
Copy link
Copy Markdown
Owner

Ocramius commented Oct 5, 2025

Remember to regenerate the lock file

@samsonasik
Copy link
Copy Markdown
Contributor Author

@Ocramius I've regenerated composer.lock 👍

@Ocramius
Copy link
Copy Markdown
Owner

Ocramius commented Oct 5, 2025

Hmm, sounds like upstream isn't ready yet, due to missing pcov for 8.5

@samsonasik
Copy link
Copy Markdown
Contributor Author

samsonasik commented Oct 5, 2025

is there a way to disable pcov for php 8.5?

@Ocramius
Copy link
Copy Markdown
Owner

Ocramius commented Oct 5, 2025

Not if mutation testing is to run. I'd rather suggest investigating what's missing for php8.5-pcov to be published

@samsonasik
Copy link
Copy Markdown
Contributor Author

samsonasik commented Oct 5, 2025

I am thinking if this can be manually on php 8.4, since mutating testing run on php 8.4

      - name: Install pcov on php 8.4
        if: matrix.operatingSystem == 'ubuntu-latest' && matrix.phpVersion == '8.4'
        run: |
          sudo apt-get install php8.4-pcov
          echo "pcov.enabled=1" >> /etc/php/8.4/cli/php.ini
          echo "pcov.directory=." >> /etc/php/8.4/cli/php.ini
          php -m | grep pcov

Then remove on .laminas-ci.json

{
-  "extensions": [
-    "pcov"
-  ],

@Ocramius
Copy link
Copy Markdown
Owner

Ocramius commented Oct 5, 2025

I'd rather not add hacks here, which I then have to maintain or revert, while all that's needed is some releasing upstream

@zll600
Copy link
Copy Markdown

zll600 commented Nov 27, 2025

HI, @samsonasik @Ocramius
As php8.5-pcov has been published, I think we can continue to support 8.5.

@samsonasik
Copy link
Copy Markdown
Contributor Author

samsonasik commented Nov 27, 2025

@zll600 I will rebase and regenerate composer.lock today/this week, ping me if I forgot, feel free to create separate PR if you're faster than me ;)

@samsonasik
Copy link
Copy Markdown
Contributor Author

I've rebased and regenerated composer.lock 👍

@Ocramius Ocramius self-assigned this Nov 27, 2025
@Ocramius Ocramius added enhancement dependencies Pull requests that update a dependency file labels Nov 27, 2025
@Ocramius Ocramius added this to the 2.11.0 milestone Nov 27, 2025
@Ocramius
Copy link
Copy Markdown
Owner

thanks @samsonasik!

@Ocramius Ocramius merged commit 6c0e962 into Ocramius:2.11.x Nov 27, 2025
14 checks passed
@samsonasik samsonasik deleted the add-php85 branch November 27, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants