Skip to content

Fix node generation when a cdata property is null#701

Merged
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
Kelgors:fix/empty-cdata
Dec 20, 2024
Merged

Fix node generation when a cdata property is null#701
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
Kelgors:fix/empty-cdata

Conversation

@Kelgors
Copy link
Contributor

@Kelgors Kelgors commented Dec 18, 2024 •
edited
Loading

Purpose / Goal

During XML building, CDATA with null value is not handled properly. When a value is null, the cdata property is ignored and treated as a normal node.

This PR aims to resolve this issue (#700) by handling the cdata property when it has a null value.

Benchmark

Before Changes

Running Suite: XML Builder benchmark
fxp : 73911.77177576702 requests/second
fxp - preserve order : 96821055.83555794 requests/second
xml2js  : 23993.824078178754 requests/second

After Changes

Running Suite: XML Builder benchmark
fxp : 71796.8171188612 requests/second
fxp - preserve order : 95102276.51741566 requests/second
xml2js  : 22884.60165181542 requests/second

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

@coveralls
Copy link

coveralls commented Dec 20, 2024

Coverage Status

coverage: 98.217% (+0.005%) from 98.212%
when pulling 60fe977 on Kelgors:fix/empty-cdata
into e132656 on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 280cd63 into NaturalIntelligence:master Dec 20, 2024
angeld7 added a commit to angeld7/fast-xml-parser that referenced this pull request Feb 19, 2025
@angeld7
Updated to fix regression of issue in NaturalIntelligence#701
fb032ef
amitguptagwl pushed a commit that referenced this pull request Feb 20, 2025
@angeld7
#711 Removed string formating on cli output (#712)
dd9a94b 
* #711 Removed string formating on cli output

* Updated to fix regression of issue in #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kelgors @coveralls @amitguptagwl