Fix '<' or '>' in DTD comment throwing an error.#533
Merged
amitguptagwl merged 6 commits intoNaturalIntelligence:devfrom Jan 25, 2023
Merged
Fix '<' or '>' in DTD comment throwing an error.#533amitguptagwl merged 6 commits intoNaturalIntelligence:devfrom
amitguptagwl merged 6 commits intoNaturalIntelligence:devfrom
Conversation
…nt and not an end tag
Member
|
I would be checking this PR soon. |
Member
|
can you please merge your change to dev branch? |
Contributor
Author
|
Did it, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
This PR fixes a bug where if a comment in the doctype definition contains '<' or '>' it throws an error. The XML specification allows '<' and '>' in comments, and does not note an exception excluding them in the DTD.
Closes #530
Benchmarks
Before
After
Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.