Fix stopNodes when same tag appears inside node#456
Merged
amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom May 18, 2022
Merged
Fix stopNodes when same tag appears inside node#456amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom
amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom
Conversation
Member
|
This PR will be merged around 16-17may. |
Contributor
Author
|
@amitguptagwl thank you!!! when will a new version be published to NPM with this change? |
Member
|
@patrickshipe there is one more PR pending to merge due to the unit tests. I'm planning to publish after that. |
Member
|
published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
When using the
stopNodesoption, if tags with the same name as the stop node are contained in the stop node, we will incorrectly close the stopped node early. This fixes that issue.Fixes: #455
Type
Please mention the type of PR
Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend
[WIP]in PR title. Your PR will be reviewed when[WIP]will be removed from the PR title.Bookmark this repository for further updates.