Fix CDATA parsing returning empty string when value = 0#451
Merged
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom Mar 31, 2022
Merged
Fix CDATA parsing returning empty string when value = 0#451amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
In V4, parsing CDATA with value 0 returns an empty string
In v3, it returned the string '0'
Type
Please mention the type of PR
Input
Expected output
latitude = 0Actual output
latitude = ''