Skip to content

Fix namspaced tag parsing#321

Merged
amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom
CamilleDrapier:fix-namspaced-tag-parsing
Feb 25, 2021
Merged

Fix namspaced tag parsing#321
amitguptagwl merged 2 commits intoNaturalIntelligence:masterfrom
CamilleDrapier:fix-namspaced-tag-parsing

Conversation

@CamilleDrapier
Copy link
Contributor

@CamilleDrapier CamilleDrapier commented Feb 22, 2021

Purpose / Goal

This is a naive attempt at solving the following issue:

#320

Please note that my experience with this repository is fairly low, so I might have missed something important.

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Benchmark

Before

Running Suite: XML Parser benchmark
validation : 29237.1202899018 requests/second
xml to json : 24875.297773092963 requests/second
xml to json + json string : 22191.624311589047 requests/second
xml to json string : 3994.622584408293 requests/second
xml2js  : 7993.719125817242 requests/second

After

Running Suite: XML Parser benchmark
validation : 29701.63520998558 requests/second
xml to json : 26255.646131059493 requests/second
xml to json + json string : 22435.547703433473 requests/second
xml to json string : 3904.6532980072416 requests/second
xml2js  : 7286.735343585023 requests/second

NB: benchmarking requires benchmark and xml2js (dev) dependencies that are currently not referenced in package.json

@coveralls
Copy link

coveralls commented Feb 22, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 87.983% when pulling 42554b6 on CamilleDrapier:fix-namspaced-tag-parsing into 4023f6d on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 51cd0dc into NaturalIntelligence:master Feb 25, 2021
This was referenced Mar 14, 2021
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
This was referenced Mar 15, 2021
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CamilleDrapier @coveralls @amitguptagwl