Merged
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Collaborator
Author
|
Will prevent events like #34 |
ArangoGutierrez
added a commit
to ArangoGutierrez/holodeck
that referenced
this pull request
Feb 12, 2026
…rmat GenerateInstanceID silently returned empty string on rand failure, producing a cache file named '.yaml'. Change to return (string, error). Also validate instance IDs match hex format in GetInstanceCacheFile to prevent path traversal. Audit findings NVIDIA#8 (MEDIUM), NVIDIA#35 (LOW). Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
10 tasks
ArangoGutierrez
added a commit
that referenced
this pull request
Feb 13, 2026
…rmat (#648) GenerateInstanceID silently returned empty string on rand failure, producing a cache file named '.yaml'. Change to return (string, error). Also validate instance IDs match hex format in GetInstanceCacheFile to prevent path traversal. Audit findings #8 (MEDIUM), #35 (LOW). Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.