Create Holodeck GitHub Action#20

Merged

ArangoGutierrez merged 7 commits intomainfrom

Feb 28, 2024

Collaborator

ArangoGutierrez commented Feb 22, 2024

No description provided.


          Use go-version-file for go version in setup-go setp

17a77c2

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez self-assigned this

elezar reviewed

View reviewed changes

.github/workflows/go.yml Show resolved Hide resolved

elezar reviewed

View reviewed changes

.github/workflows/image.yml Show resolved Hide resolved

elezar reviewed

View reviewed changes

.github/workflows/image.yml Show resolved Hide resolved

elezar reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

elezar reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

elezar reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

ArangoGutierrez added 4 commits

February 22, 2024 11:12


          Add Dockerfile for container gh action

e28e83e

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>


          Add GitHub action to build image

4aabd1e

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>


          Add missing license headers

03a83de

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>


          Add GitHub action file

0c466f7

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez force-pushed the ghaction branch from 46698c5 to bb628dc Compare

February 22, 2024 11:33

ArangoGutierrez marked this pull request as ready for review

February 22, 2024 11:35

ArangoGutierrez requested review from cdesiniotis and tariq1890 as code owners

February 22, 2024 11:35

ArangoGutierrez requested a review from elezar

February 22, 2024 11:35

ArangoGutierrez force-pushed the ghaction branch 2 times, most recently from dfa9a8a to e1bdb2a Compare

February 22, 2024 11:37

ArangoGutierrez added maintenance testing maintenance and removed maintenance labels

elezar reviewed

View reviewed changes

Member

elezar left a comment

Question about leaking secrets into logs.

scripts/run.sh Show resolved Hide resolved

scripts/run.sh Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the ghaction branch from e1bdb2a to 08fc7e3 Compare

February 23, 2024 14:48

ArangoGutierrez requested a review from elezar

February 23, 2024 14:48

Collaborator Author

ArangoGutierrez commented Feb 26, 2024

@elezar PTAL, I think is ready for another round

elezar reviewed

View reviewed changes

Member

elezar left a comment

Thanks @ArangoGutierrez.

I have some questions. They should not be blockers though.

.github/workflows/image.yml Show resolved Hide resolved

action.yml Show resolved Hide resolved

scripts/cleanup.sh Outdated Show resolved Hide resolved

scripts/run.sh Outdated Show resolved Hide resolved

scripts/run.sh Show resolved Hide resolved

Dockerfile Show resolved Hide resolved

ArangoGutierrez requested a review from tariq1890

February 27, 2024 10:40


          Add entrypoint and cleanup scripts for github action

7a6db4c

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez force-pushed the ghaction branch from 08fc7e3 to 7a6db4c Compare

February 27, 2024 11:29

Collaborator Author

ArangoGutierrez commented Feb 27, 2024

elezar reviewed

View reviewed changes

action.yml Outdated Show resolved Hide resolved

elezar reviewed

View reviewed changes

action.yml Outdated Show resolved Hide resolved

ArangoGutierrez requested a review from elezar

February 27, 2024 13:00

ArangoGutierrez force-pushed the ghaction branch 2 times, most recently from 68845da to 192186d Compare

February 27, 2024 14:34

elezar reviewed

View reviewed changes

scripts/cleanup.sh Show resolved Hide resolved

ArangoGutierrez force-pushed the ghaction branch 2 times, most recently from ca60d06 to 3f1d6fc Compare

February 28, 2024 09:40

ArangoGutierrez requested a review from elezar

February 28, 2024 09:46

ArangoGutierrez force-pushed the ghaction branch 2 times, most recently from 8b8542c to af9ba37 Compare

February 28, 2024 10:11

elezar reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the ghaction branch from af9ba37 to 69cfd1d Compare

February 28, 2024 10:41

ArangoGutierrez requested a review from elezar

February 28, 2024 10:41


          Update action.yml

1e8d3af

Co-authored-by: Evan Lezar <evanlezar@gmail.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez force-pushed the ghaction branch from 69cfd1d to 1e8d3af Compare

February 28, 2024 12:06

Collaborator Author

ArangoGutierrez commented Feb 28, 2024

All comments addressed @elezar

elezar approved these changes

View reviewed changes

ArangoGutierrez merged commit 22998dc into main

ArangoGutierrez deleted the ghaction branch

February 28, 2024 14:02

ArangoGutierrez added a commit to ArangoGutierrez/holodeck that referenced this pull request


          perf(cluster): parallelize node provisioning, join info, source/dest …

…check

provisionBaseOnAllNodes now provisions all nodes concurrently using
errgroup (was sequential — N*5min). extractJoinInfo combines 3 SSH
sessions into 1 script. disableSourceDestCheck runs API calls in
parallel instead of sequentially.

Audit findings NVIDIA#20 (MEDIUM), NVIDIA#21 (MEDIUM), NVIDIA#25 (MEDIUM).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez mentioned this pull request

perf(cluster): parallelize node provisioning, join info, source/dest check #660

Merged

3 tasks

ArangoGutierrez added a commit to ArangoGutierrez/holodeck that referenced this pull request


          perf(cluster): parallelize node provisioning, join info, source/dest …

713cedc

…check

provisionBaseOnAllNodes now provisions all nodes concurrently using
errgroup (was sequential — N*5min). extractJoinInfo combines 3 SSH
sessions into 1 script. disableSourceDestCheck runs API calls in
parallel instead of sequentially.

Audit findings NVIDIA#20 (MEDIUM), NVIDIA#21 (MEDIUM), NVIDIA#25 (MEDIUM).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez added a commit to ArangoGutierrez/holodeck that referenced this pull request


          perf(cluster): parallelize node provisioning, join info, source/dest …

b802204

…check

provisionBaseOnAllNodes now provisions all nodes concurrently using
errgroup (was sequential — N*5min). extractJoinInfo combines 3 SSH
sessions into 1 script. disableSourceDestCheck runs API calls in
parallel instead of sequentially.

Audit findings NVIDIA#20 (MEDIUM), NVIDIA#21 (MEDIUM), NVIDIA#25 (MEDIUM).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez added a commit to ArangoGutierrez/holodeck that referenced this pull request


          perf(cluster): parallelize node provisioning, join info, source/dest …

9ae13ff

…check

provisionBaseOnAllNodes now provisions all nodes concurrently using
errgroup (was sequential — N*5min). extractJoinInfo combines 3 SSH
sessions into 1 script. disableSourceDestCheck runs API calls in
parallel instead of sequentially.

Audit findings NVIDIA#20 (MEDIUM), NVIDIA#21 (MEDIUM), NVIDIA#25 (MEDIUM).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez added a commit that referenced this pull request


          perf(cluster): parallelize node provisioning, join info, source/dest …

6207ab0

…check (#660)

provisionBaseOnAllNodes now provisions all nodes concurrently using
errgroup (was sequential — N*5min). extractJoinInfo combines 3 SSH
sessions into 1 script. disableSourceDestCheck runs API calls in
parallel instead of sequentially.

Audit findings #20 (MEDIUM), #21 (MEDIUM), #25 (MEDIUM).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance testing