Merged
Conversation
elezar
reviewed
Jan 6, 2025
bee9821 to
df0dab4
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
df0dab4 to
30b1cf0
Compare
elezar
reviewed
Jan 10, 2025
elezar
approved these changes
Jan 10, 2025
Member
elezar
left a comment
There was a problem hiding this comment.
Thanks @tariq1890
I think we can do some additional refactoring by introducing a sysDevice type, for example. I don't think that's a blocker for the intent of this PR though.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.