Conversation
Gudahtt
reviewed
Nov 8, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Nov 8, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sourcemaps that are generated from the
error.tscode are wrong. They seem to be having trouble with the@ts-ignorecomment and some combination of the ternary statement. Unrolling the ternary into an if...else seems to resolve the issue, thoough a longer term fix would be to bump the tsconfigtargetfield toES2022and remove the@ts-ignoresee https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/62187/workflows/98ccf0cb-168e-47d3-8d7e-b5e10edc129b/jobs/1964980 for more details