First part of a solution for fixing JSON validation security issue#103
Merged
First part of a solution for fixing JSON validation security issue#103
Conversation
Contributor
|
We should merge all parts of this task at the same time so as not to have a release with unsafe JSON. |
Mrtenz
requested changes
May 19, 2023
Mrtenz
reviewed
May 23, 2023
Mrtenz
requested changes
May 23, 2023
ritave
reviewed
May 23, 2023
Mrtenz
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part to fix an issue around JSON validation.
Second part (PR): MetaMask/snaps#1405
Explanation
This PR resolves the security issue with JSON validation and usage of the validated objects.
JsonStructis updated to usecoerceinstead ofdefineand it does sanitization now by havingJSON.parse(JSON.stringify(value))as the return value.From now it is supposed that validation is done using
createfunction from Superstruct which will return validated and sanitized JSON. New functiongetValidatedAndSanitizedJsonwhich handles this is added.isValidJsonfunction is updated in order to use newJsonStructand keep its return values the same.On the places (e.g.
snaps-monorepo) where JSON structure is validated and used later in the process,getValidatedAndSanitizedJsonshould always be used.