Fix missing global in eval-worker#2072
Merged
FrederikBolding merged 1 commit intomainfrom Jan 5, 2024
Merged
Conversation
global in eval-worker
d86a267 to
ee9d530
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 96.28% 96.28%
=======================================
Files 270 270
Lines 6300 6300
Branches 1017 1017
=======================================
Hits 6066 6066
Misses 234 234 ☔ View full report in Codecov by Sentry. |
hmalik88
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
globalglobal was missing in the eval-worker, causing eval to fail when a snap tried to accessglobal.This PR changes the eval-worker to mirror the
BaseSnapExecutor, setting up the endowments as globals in an identical way: https://github.com/MetaMask/snaps/blob/main/packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts#L404-L417