Upstream derivation path logic from the extension client#2033
Merged
FrederikBolding merged 3 commits intomainfrom Dec 13, 2023
Merged
Upstream derivation path logic from the extension client#2033FrederikBolding merged 3 commits intomainfrom
FrederikBolding merged 3 commits intomainfrom
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Mrtenz
requested changes
Dec 13, 2023
f0c9f11 to
9779936
Compare
Mrtenz
approved these changes
Dec 13, 2023
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
9779936 to
980110c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
+ Coverage 96.10% 96.11% +0.01%
==========================================
Files 269 270 +1
Lines 6286 6307 +21
Branches 1011 1021 +10
==========================================
+ Hits 6041 6062 +21
Misses 245 245 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreams derivation path logic from the extension client to be used across all clients.
Fixes #1467