BREAKING: Synchronously initialise WASM modules#2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
+ Coverage 96.08% 96.10% +0.01%
==========================================
Files 269 269
Lines 6262 6286 +24
Branches 1010 1011 +1
==========================================
+ Hits 6017 6041 +24
Misses 245 245 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
experimental.wasmflag in the Snaps CLI is enabled, the WASM module will now be synchronously initialised, rather than being inlined as aUint8Array.For example, if the WASM module exports a
fibonaccifunction, the following is now possible:This is a breaking change, because previously the WASM module would be inlined as
Uint8Arrayinstead.