Fix idle snap timeout for unused snap#2010
Merged
FrederikBolding merged 1 commit intomainfrom Dec 4, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 269 269
Lines 6259 6261 +2
Branches 1009 1009
=======================================
+ Hits 6014 6016 +2
Misses 245 245 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Dec 4, 2023
eae95ab to
da5c01d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a snap that never had an incoming RPC request would never be torn down by the idle timeout.