Skip to content

Bump base-controller and permission-controller#1989

Merged
FrederikBolding merged 4 commits intomainfrom
fb/bump-base-controller
Dec 1, 2023
Merged

Bump base-controller and permission-controller#1989
FrederikBolding merged 4 commits intomainfrom
fb/bump-base-controller

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

This PR bumps base-controller and permission-controller to the latest version. It also handles some breaking changes in the latest version of base-controller.

Replaces #1988
Replaces #1986

@socket-security
Copy link
Copy Markdown

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/permission-controller 5.0.1...6.0.0 None +0/-25 413 kB metamaskbot

🚮 Removed packages: @metamask/base-controller@3.2.3

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d24892) 96.08% compared to head (94ea844) 96.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1989   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         267      267           
  Lines        6230     6230           
  Branches     1007     1007           
=======================================
  Hits         5986     5986           
  Misses        244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review November 24, 2023 14:06
@FrederikBolding FrederikBolding requested a review from a team as a code owner November 24, 2023 14:06
@FrederikBolding FrederikBolding force-pushed the fb/bump-base-controller branch from f322e7d to 94ea844 Compare December 1, 2023 09:41
@FrederikBolding FrederikBolding merged commit a6ea785 into main Dec 1, 2023
@FrederikBolding FrederikBolding deleted the fb/bump-base-controller branch December 1, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants