Skip to content

devDeps: @lavamoat/allow-scripts@1.0.6->2.3.1#93

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:devdeps-lavamoat-allow-scripts
Jul 27, 2023
Merged

devDeps: @lavamoat/allow-scripts@1.0.6->2.3.1#93
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:devdeps-lavamoat-allow-scripts

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Jul 26, 2023 •
edited
Loading

Blocked by #92

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 26, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/allow-scripts 1.0.6...2.3.1 shell, environment +74/-68 6.61 MB lgbot

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jul 26, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @lavamoat/allow-scripts@2.3.1, json-parse-even-better-errors@3.0.0, fs-minipass@3.0.2, @npmcli/node-gyp@3.0.0, are-we-there-yet@3.0.1, npmlog@6.0.2, read-cmd-shim@4.0.0, npm-normalize-package-bin@3.0.1, which@3.0.1, write-file-atomic@5.0.1, nopt@6.0.0, exponential-backoff@3.1.1, foreground-child@3.1.1, @lavamoat/aa@3.1.2, minipass-collect@1.0.2, minipass-pipeline@1.2.4, indent-string@4.0.0, retry@0.12.0, smart-buffer@4.2.0, @tootallnate/once@2.0.0, aggregate-error@3.1.0, negotiator@0.6.3, minipass-sized@1.0.3, depd@2.0.0, err-code@2.0.3, promise-retry@2.0.1, iconv-lite@0.6.3, color-support@1.1.3, minipass-flush@1.0.5, humanize-ms@1.2.1, encoding@0.1.13, ip@2.0.0, is-lambda@1.0.1, http-proxy-agent@5.0.0, https-proxy-agent@5.0.1, socks-proxy-agent@7.0.0, make-fetch-happen@11.1.1, minipass-fetch@3.0.3, agentkeepalive@4.3.0, socks@2.7.1, glob@10.3.3, path-scurry@1.10.1, cacache@17.1.3, @npmcli/fs@3.1.0, bin-links@4.0.1, cmd-shim@6.0.1, read-package-json-fast@3.0.2

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from f066452 to 46f425b Compare July 26, 2023 22:37
@legobeat

This comment was marked as resolved.

Sign in to view
@legobeat legobeat marked this pull request as ready for review July 26, 2023 22:42
@legobeat legobeat requested a review from a team as a code owner July 26, 2023 22:42
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 46f425b to 8f28d05 Compare July 27, 2023 00:06
Gudahtt
Gudahtt approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 5dd20b6 into MetaMask:main Jul 27, 2023
@legobeat legobeat deleted the devdeps-lavamoat-allow-scripts branch May 21, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Gudahtt