Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

devDeps: @lavamoat/allow-scripts@^2.3.0->^3.0.0#168

Merged
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:devDeps-allow-scripts
Oct 23, 2023
Merged

devDeps: @lavamoat/allow-scripts@^2.3.0->^3.0.0#168
legobeat merged 2 commits intoMetaMask:mainfrom
legobeat:devDeps-allow-scripts

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Oct 23, 2023

No description provided.

@legobeat legobeat added the type-dependencies Pull requests that update a dependency file label Oct 23, 2023
@legobeat legobeat marked this pull request as ready for review October 23, 2023 13:18
@legobeat legobeat requested a review from a team as a code owner October 23, 2023 13:18
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 23, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/allow-scripts 2.3.0...3.0.0 network, shell +62/-65 6.29 MB naugtur

@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 23, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: json-parse-even-better-errors@3.0.0, @npmcli/node-gyp@3.0.0, are-we-there-yet@3.0.1, npmlog@6.0.2, which@3.0.1, nopt@6.0.0, exponential-backoff@3.1.1, foreground-child@3.1.1, make-fetch-happen@11.1.1, minipass-fetch@3.0.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Oct 23, 2023 

@SocketSecurity ignore minipass-fetch@3.0.4

network access ok

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Oct 23, 2023 

@SocketSecurity ignore foreground-child@3.1.1

shell access ok

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Oct 23, 2023 

@SocketSecurity ignore make-fetch-happen@11.1.1

network access ok

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Oct 23, 2023 

@SocketSecurity ignore json-parse-even-better-errors@3.0.0
@SocketSecurity ignore @npmcli/node-gyp@3.0.0
@SocketSecurity ignore are-we-there-yet@3.0.1
@SocketSecurity ignore npmlog@6.0.2
@SocketSecurity ignore which@3.0.1
@SocketSecurity ignore nopt@6.0.0
@SocketSecurity ignore exponential-backoff@3.1.1

new author ok

@legobeat legobeat merged commit 73e5f44 into MetaMask:main Oct 23, 2023
@legobeat legobeat deleted the devDeps-allow-scripts branch October 23, 2023 13:48
legobeat added a commit to legobeat/eth-simple-keyring that referenced this pull request Oct 2, 2024
@legobeat
devDeps: @lavamoat/allow-scripts@^2.3.0->^3.0.0 (MetaMask#168)
bb30db6
@legobeat legobeat mentioned this pull request Oct 2, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Mrtenz Mrtenz Mrtenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Mrtenz