Enforce specification of return types in TypeScript#314
Merged
Conversation
Enable the `@typescript-eslint/explicit-function-return-type` rule, which enforces that return types are specified for all functions. Being explicit about the return type makes it easier to see type without having to open the code in an editor, and communicating what a function _ought_ to return prevents bugs from sneaking in (in case the return value is not being tested).
Member
|
Looks great! Snapshots need updating though |
legobeat
approved these changes
Jul 26, 2023
Contributor
legobeat
left a comment
There was a problem hiding this comment.
Best new rule this year!
Mrtenz
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
@typescript-eslint/explicit-function-return-typerule, which enforces that return types are specified for all functions. Being explicit about the return type makes it easier to see it without having to open the code in an editor, and communicating what a function ought to return prevents bugs from sneaking in (in case the return value is not being tested).Extracted from MetaMask/contributor-docs#11 (comment).
Enabling this on
corewould produce 603 violations.Enabling this on
snapswould produce 571 violations.