Skip to content

Add NPM_TOKEN to publish-release workflow call#259

Merged
Mrtenz merged 1 commit intomainfrom
mrtenz/add-npm-token
Nov 17, 2022
Merged

Add NPM_TOKEN to publish-release workflow call#259
Mrtenz merged 1 commit intomainfrom
mrtenz/add-npm-token

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Nov 17, 2022

Secrets in a workflow called through workflow_call require secrets to be defined explicitly: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow

@Mrtenz Mrtenz requested a review from a team as a code owner November 17, 2022 16:28
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit e48fb25 into main Nov 17, 2022
@Mrtenz Mrtenz deleted the mrtenz/add-npm-token branch November 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants