Merged
Conversation
3 tasks
Gudahtt
added a commit
that referenced
this pull request
May 9, 2024
## Explanation The version of the `@metamask/profile-sync-controller` package has been updated to `0.0.0`, which is what our publishing automation expects of all unpublished public packages. The current version is `0.1.0`, which caused problems for our most recent release, requiring a rollback. It broke publishing because our publishing scripts tried to find version `0.1.0` in the package changelog but were unable to. This should have been caught by our linter, but it wasn't due to a deficiency in the `@metamask/auto-changelog` validation command (it doesn't validate that the current release exists). This problem has been documented here: MetaMask/auto-changelog#192 ## References Unblocks #4272 ## Changelog N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Gudahtt
reviewed
May 9, 2024
Gudahtt
reviewed
May 9, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
May 9, 2024
Gudahtt
previously approved these changes
May 9, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! One suggested improvement pending, not super important though
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major release of
TransactionControllerandUserOperationControllerto support gas fee updates in the extension.Breaking changes added to changelog, no dependencies on unreleased packages.
Related: