Merged
Conversation
…d snaps dependencies
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-snap-keyring@4.0.0, npm/@metamask/keyring-api@6.0.0, npm/@noble/ed25519@1.7.3, npm/@noble/secp256k1@1.7.1, npm/@types/uuid@9.0.8 |
mcmire
reviewed
May 7, 2024
package.json
Outdated
| "pre-push": "yarn lint" | ||
| }, | ||
| "resolutions": { | ||
| "@metamask/snaps-sdk": "4.0.1", |
Contributor
There was a problem hiding this comment.
Why do we need this resolution? This seems to indicate a misalignment between dependencies and so it would be great if we can avoid this because it means that clients may need to apply the same resolution in order to use the packages in this repo.
Contributor
Author
There was a problem hiding this comment.
This can be removed. I originally thought this would help fix a type issue with the snaps sdk, the new version fixed it.
ccharly
reviewed
May 17, 2024
ccharly
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This pull request updates the following dependencies
@metamask/keyring-apito^6.1.1,@metamask/eth-snap-keyringto^4.1.1@metamask/snaps-utilsto^7.4.0@metamask/snaps-controllersto^8.1.1References
Changelog
Checklist