Add a metadata property for nonRPCGasFeeApisDisabled#4245
Merged
Conversation
vthomas13
approved these changes
May 2, 2024
matthewwalsh0
approved these changes
May 2, 2024
7 tasks
7 tasks
This was referenced May 10, 2024
Merged
Closed
Merged
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
Patch release of `GasFeeController` to fix an error being thrown in the extension background. This includes the PR #4245 --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This should have been part of #4094
The absence of this metadata results in an error being thrown from here: https://github.com/MetaMask/core/blob/main/packages/base-controller/src/BaseControllerV2.ts#L295-L297
Changelog
FIXED: Add metadata for the
nonRPCGasFeeApisDisabledof gas-fee-controller state@metamask/gas-fee-controllernonRPCGasFeeApisDisabledof gas-fee-controller stateChecklist