Skip to content

Check labels for a PR when it is updated#4005

Merged
mcmire merged 2 commits intomainfrom
check-labels-on-synchronize
Feb 29, 2024
Merged

Check labels for a PR when it is updated#4005
mcmire merged 2 commits intomainfrom
check-labels-on-synchronize

Conversation

@mcmire
Copy link
Copy Markdown
Contributor

@mcmire mcmire commented Feb 29, 2024

Explanation

Updating a branch against its base branch from the GitHub UI seems to reset the status of the ensure-blocking-pr-labels-absent check, but since it only runs when a PR is opened or when labels are added or removed, it won't get run again, keeping the PR in limbo. Adding synchronize to the list of actions fixes this.

Changelog

(N/A)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Updating a branch against its base branch from the GitHub UI seems to
reset the status of the `ensure-blocking-pr-labels-absent` check, but
since it only runs when a PR is opened or when labels are added or
removed, it won't get run again, keeping the PR in limbo. Adding
`synchronize` to the list of actions fixes this.
@mcmire mcmire requested a review from a team as a code owner February 29, 2024 21:16
Copy link
Copy Markdown
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 346331d into main Feb 29, 2024
@mcmire mcmire deleted the check-labels-on-synchronize branch February 29, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants