Skip to content

refactor: Remove duplicated code in setProviderType#3813

Merged
Gudahtt merged 1 commit intomainfrom
refactor-set-provider-type-to-remove-redundancy
Jan 22, 2024
Merged

refactor: Remove duplicated code in setProviderType#3813
Gudahtt merged 1 commit intomainfrom
refactor-set-provider-type-to-remove-redundancy

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Jan 22, 2024

Explanation

The method setProviderType has been updated to use setActiveNetwork internally, allowing us to remove a bunch of code that was duplicated between both methods.

References

N/A

Changelog

None

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt Gudahtt force-pushed the refactor-set-provider-type-to-remove-redundancy branch from 3d9c8f8 to 05d004a Compare January 22, 2024 18:43
The method `setProviderType` has been updated to use `setActiveNetwork`
internally, allowing us to remove a bunch of code that was duplicated
between both methods.
@Gudahtt Gudahtt force-pushed the refactor-set-provider-type-to-remove-redundancy branch from 05d004a to cf58295 Compare January 22, 2024 18:45
@Gudahtt Gudahtt marked this pull request as ready for review January 22, 2024 18:52
@Gudahtt Gudahtt requested a review from a team as a code owner January 22, 2024 18:52
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Gudahtt Gudahtt merged commit ef35512 into main Jan 22, 2024
@Gudahtt Gudahtt deleted the refactor-set-provider-type-to-remove-redundancy branch January 22, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants