Fix use estimate gas instead of fixed gas#3694
Merged
vinistevam merged 3 commits intomainfrom Dec 21, 2023
Merged
Conversation
matthewwalsh0
approved these changes
Dec 21, 2023
13 tasks
vinistevam
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jan 10, 2024
## **Description** Bump transaction controller to: - Fix to properly estimate the gas instead of using a fixed gas when deploying a contract without specifying the `gas`. See [related core PR](MetaMask/core#3694). ## **Related issues** Fixes: #22359 ## **Manual testing steps** - Transaction regression **Scenario of the error** 1. Go to https://stackblitz.com/github/wevm/viem/tree/main/examples/contracts_deploying-contracts 2. Wait for the example to build 3. Connect MM 4. Click deploy 5. Submit tx 6. Contract should deploy successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fix following the full release of the core
TransactionControllerin the extension:gasis not specified.References
Changelog
@metamask/transaction-controllertoproperty is not provided.Checklist