Skip to content

OpenSea supply -> total_supply#3692

Merged
bergeron merged 1 commit intomainfrom
brian/os-supply
Dec 20, 2023
Merged

OpenSea supply -> total_supply#3692
bergeron merged 1 commit intomainfrom
brian/os-supply

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

Explanation

OpenSea renamed the field supply, which used to be required, to total_supply. Fixes the error:

undefined is not an object (evaluating 'contract.supply.toString')

A more accurate total_supply was also added to the collection object, which is now preferred to the one on the contract.

References

Changelog

@metamask/assets-controllers

  • FIXED: OpenSea response from supply to total_supply

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@bergeron bergeron requested a review from a team as a code owner December 20, 2023 18:39
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergeron bergeron merged commit 6884767 into main Dec 20, 2023
@bergeron bergeron deleted the brian/os-supply branch December 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants