Account for tiny time differences between commits#113
Merged
Conversation
When two tags are created in a repo that differ by mere milliseconds or smaller, such as would happen in an automated high-level test of the `create-release-pr` action, `git rev-list --tags` seems to get confused, and so `getMostRecentTag` may not always return the latest tag. Adding `--date-order` seems to fix this.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two tags are created in a repo that differ by mere milliseconds or
smaller, such as would happen in an automated high-level test of the
create-release-praction,git rev-list --tagsseems to get confused,and so
getMostRecentTagmay not always return the latest tag. Adding--date-orderseems to fix this.