Skip to content

Read repository from package.json if npm_package_repository_url is not set#111

Merged
Mrtenz merged 2 commits intomainfrom
mz/repo-from-package-json
May 16, 2022
Merged

Read repository from package.json if npm_package_repository_url is not set#111
Mrtenz merged 2 commits intomainfrom
mz/repo-from-package-json

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented May 16, 2022

In Yarn 3, npm_package_repository_url isn't set, and auto-changelog fails to parse the repository. In this PR I added a function which first looks at the npm_package_repository_url, and if that doesn't exist, looks at PROJECT_CWD instead. From there the package.json can be parsed in order to get the repository automatically.

For details on Yarn 3 environment variables, see here.

@Mrtenz Mrtenz requested a review from a team as a code owner May 16, 2022 12:45
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit e48ffd0 into main May 16, 2022
@Mrtenz Mrtenz deleted the mz/repo-from-package-json branch May 16, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants