Skip to content

Add Types for JaCoCo XML object#95

Merged
thsaravana merged 7 commits into
mainfrom
jacoco-types
Aug 31, 2024
Merged

Add Types for JaCoCo XML object#95
thsaravana merged 7 commits into
mainfrom
jacoco-types

Conversation

@thsaravana

Copy link
Copy Markdown
Member

The JaCoCo XML object didn't have any Type information. Instead we basically treated it as any at every point. This was causing a lot of errors in the code.
So now, we will convert the XML to a Report which is Typed properly and we can safely access it. If the XML report itself is faulty, we will throw an error.

PS: There are still places in code, where we are doing calculations that could cause NaN. But I will fix these in another PR. For now, I kept the code as is.

@thsaravana thsaravana requested a review from instrap August 31, 2024 08:38
@thsaravana thsaravana self-assigned this Aug 31, 2024
@thsaravana thsaravana merged commit 2dd19a5 into main Aug 31, 2024
@thsaravana thsaravana deleted the jacoco-types branch August 31, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants