Fix 32bit tests#331
Merged
Lokathor merged 4 commits intoLokathor:mainfrom Nov 7, 2025
Merged
Conversation
Owner
|
Looks like the CI failure is just from the CI rust version needing to be updated to something newer. If you do that, I think the Cargo.toml notes about what feature is what msrv might need an update as well. |
|
The change seems to have broken tests on armhf as reported in #345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330 for i686-unknown-linux-gnu, not sure about s390x.
Also addresses a test failure for
try_from_box_byteson i686-unknown-linux-gnu (the conversion was intended to fail with AlignmentMismatch, but failed with SizeMismatch becauseu32andu64have the same alignment on that target)