Merged
Conversation
added 4 commits
May 28, 2025 14:51
Fix [issue KyleKing#51](KyleKing#51): Python Markdown Extensions captions, which are availble in Material for MkDocs, get destroyed when using `--wrap`. The caption ```markdown /// table-caption | 1.5.2 A table with letters. /// ``` was formatted as ```markdown /// table-caption | 1.5.2 A table with letters. /// ``` thus breaking the rendered caption in Material for MkDocs. Now, we detect these captions as a token and avoid losing their delitimers.
KyleKing
reviewed
May 30, 2025
Owner
KyleKing
left a comment
There was a problem hiding this comment.
Thank you so much! I have a few minor comments and would like to see a test for the rendered HTML, but otherwise this looks great and is nearly ready to merge!
added 2 commits
May 30, 2025 09:20
Implement comments in PR review by author: - Named capture groups in REs. - Only use `paragraph` in `alt` for captions. - Wrap caption's content in a <p>. - Strip content to get rid of captured newline in caption content.
Contributor
Author
|
Thank you very much for the quick and insightful review! I have implemented the suggestions and I see a noticeable improvement. I have left the correct HTML conversation open, in case we want to consider properly capturing things in a |
KyleKing
approved these changes
May 30, 2025
Owner
KyleKing
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me and I'll make a release this evening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #51 : Python Markdown Extensions captions, which are availble in Material for MkDocs, get destroyed when using
--wrap.The caption
was formatted as
thus breaking the rendered caption in Material for MkDocs.
Now, we detect these captions as a token and avoid losing their delitimers.