Merged
Conversation
Owner
|
We need to introduce I'll address the questions you asked on the description soon - it may be faster for me to just apply the answers in code. Thanks for the PR @jhnstrk . This is really helpful 👍 |
Owner
|
We need to add the |
Closed
Contributor
Author
|
Thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds typing sufficient to pass
mypy --strictchecks.The changes attempt to keep the public-facing API as close to unchanged as possible.
Internally there are some points that required design choices that are debatable:
assertin the code for type narrowing: is this "forbidden" here, or not? A few instances were added here. It may have a small performance impact, and could cause some existing code to fail.typing.cast. This should not have an impact, but could also be replaced with# type: ignorecomments.testspass mypy, but I'm not sure test code needs to pass type checks.I also added mypy to the Github actions.
With the changes, the unit tests pass, and performance (parsing throughput) seems unchanged.