Don't mark generated linked atomic queues as final

kay · kay · commit 9db418cd41a0 · 2019-03-03T13:48:38.000Z
Reported in #208, fixed but subsequent regressed as fix edited generated source. This change should fix it permanently.
diff --git a/jctools-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicArrayQueueGenerator.java b/jctools-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicArrayQueueGenerator.java
@@ -551,14 +551,16 @@ public static void main(String[] args) throws Exception {
             }
             outputFileName += ".java";
 
+            File outputFile = new File(outputDirectory, outputFileName);
             try {
-                writer = new FileWriter(new File(outputDirectory, outputFileName));
+                writer = new FileWriter(outputFile);
                 writer.write(cu.toString());
             } finally {
                 if (writer != null) {
                     writer.close();
                 }
             }
+            System.out.println("Saved to " + outputFile);
         }
     }
 
diff --git a/jctools-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicLinkedQueueGenerator.java b/jctools-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicLinkedQueueGenerator.java
@@ -89,7 +89,6 @@ public void visit(ClassOrInterfaceDeclaration node, Void arg) {
              * Special case for MPSC
              */
             node.removeModifier(Modifier.ABSTRACT);
-            node.addModifier(Modifier.FINAL);
         }
 
         if (isCommentPresent(node, GEN_DIRECTIVE_CLASS_CONTAINS_ORDERED_FIELD_ACCESSORS)) {

Original file line number	Diff line number	Diff line change
`@@ -551,14 +551,16 @@ public static void main(String[] args) throws Exception {`
`551`	`551`	`}`
`552`	`552`	`outputFileName += ".java";`
`553`	`553`
	`554`	`+ File outputFile = new File(outputDirectory, outputFileName);`
`554`	`555`	`try {`
`555`		`- writer = new FileWriter(new File(outputDirectory, outputFileName));`
	`556`	`+ writer = new FileWriter(outputFile);`
`556`	`557`	`writer.write(cu.toString());`
`557`	`558`	`} finally {`
`558`	`559`	`if (writer != null) {`
`559`	`560`	`writer.close();`
`560`	`561`	`}`
`561`	`562`	`}`
	`563`	`+ System.out.println("Saved to " + outputFile);`
`562`	`564`	`}`
`563`	`565`	`}`
`564`	`566`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,6 @@ public void visit(ClassOrInterfaceDeclaration node, Void arg) {`
`89`	`89`	`* Special case for MPSC`
`90`	`90`	`*/`
`91`	`91`	`node.removeModifier(Modifier.ABSTRACT);`
`92`		`- node.addModifier(Modifier.FINAL);`
`93`	`92`	`}`
`94`	`93`
`95`	`94`	`if (isCommentPresent(node, GEN_DIRECTIVE_CLASS_CONTAINS_ORDERED_FIELD_ACCESSORS)) {`