Restoring CheckModules as deprecated code#1939
Merged
arnaudgiuliani merged 5 commits intoAug 27, 2024
Merged
Conversation
(cherry picked from commit 3378cbc) Signed-off-by: pedrofsn <pedrokra@gmail.com>
Contributor
Author
|
Fixes #1938 |
Member
|
Ok sounds fair to keep it back 👍 |
Member
|
just updated main branch to let examples uses RC1 version instead of Beta1 |
Member
|
can you rebase on last branch? |
examples app use RC1
Contributor
Author
|
I'm without a computer right now, so I did using GH PR flow. 🙃 |
Member
|
Ok, I'll check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring @arnaudgiuliani previous commit and adding fancy deprecation. And of course, unit test.
It will avoid an huge breaking change for big projects migrating Koin 3.x to Koin 4.x.