fix(flatten): use LinkedHashSet instead of HashSet#1841
Merged
Conversation
to maintain the insertion order
Member
|
still get error, but order is maintained in the reverse order I see 🤔 @Test
fun `allow overrides by type`() {
val app = koinApplication {
modules(
module {
single<Simple.ComponentInterface1> { Simple.Component2() }
},
module {
single<Simple.ComponentInterface1> { Simple.Component1() }
},
)
}
app.assertDefinitionsCount(1)
assertTrue(app.koin.get<Simple.ComponentInterface1>() is Simple.Component1)
}Good thing is that order seems stable
|
Member
|
Could test that with this test too: @Test
fun test_flatten_list() {
(1..100).all { i ->
val modules = listOf(module { },module { },module { },module { },module { },module { },module { },module { },module { },module { })
val flatten = flatten(modules)
flatten.reversed() == modules
}
} |
ArrayDeque(modules.asReversed())
Contributor
Author
|
@arnaudgiuliani just updated -ArrayDeque(modules)
+ArrayDeque(modules.asReversed()) |
Member
|
Sounds good 🎉. Need to check the fails on test examples 🤔 |
Member
|
Seen the problem. It's not from your side 👍 Will fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to maintain the insertion order