Skip to content

[maintenance] androidContext readability#1655

Merged
arnaudgiuliani merged 6 commits into
InsertKoinIO:3.6.0from
GrzegorzBobryk:maintenance/androidContext_readability
Jul 15, 2024
Merged

[maintenance] androidContext readability#1655
arnaudgiuliani merged 6 commits into
InsertKoinIO:3.6.0from
GrzegorzBobryk:maintenance/androidContext_readability

Conversation

@GrzegorzBobryk

@GrzegorzBobryk GrzegorzBobryk commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

I have got second thoughts after previous pr. It was harder to read than it needed to be. I do not know if you care about such small things, but here is my proposition. :)

Improved readability by removing double usage of koin.loadModules(listOf(module {

@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from 589daf1 to c1bffbf Compare October 9, 2023 15:36
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from c1bffbf to 7280f54 Compare December 28, 2023 21:56
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from 7280f54 to dc91050 Compare February 2, 2024 14:40
@GrzegorzBobryk GrzegorzBobryk force-pushed the maintenance/androidContext_readability branch from dc91050 to 482942a Compare June 3, 2024 07:52
Improved readability by removing double usage of `listOf` and `module`.
@arnaudgiuliani arnaudgiuliani changed the base branch from main to 3.6.0 July 15, 2024 07:11
@arnaudgiuliani

Copy link
Copy Markdown
Member

thanks @GrzegorzBobryk

@arnaudgiuliani arnaudgiuliani merged commit 5fb1d9b into InsertKoinIO:3.6.0 Jul 15, 2024
@arnaudgiuliani arnaudgiuliani added this to the 3.6.0-Beta5 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants