Handle unhashable modules in constants collection#4661
Merged
Zac-HD merged 2 commits intoHypothesisWorks:masterfrom Feb 16, 2026
Merged
Handle unhashable modules in constants collection#4661Zac-HD merged 2 commits intoHypothesisWorks:masterfrom
Zac-HD merged 2 commits intoHypothesisWorks:masterfrom
Conversation
Some packages (e.g. cog) place unhashable objects like SimpleNamespace in sys.modules. This caused a TypeError when _get_local_constants tried to build a set from sys.modules.values(). Fix by catching TypeError on the membership check and falling back to tracking by module name (the str key in sys.modules) for unhashable entries. https://claude.ai/code/session_01PQkqWu11828t7hwzAyR1sZ
- Use :class:`~types.SimpleNamespace` cross-ref in RELEASE.rst - Wrap sys.modules.items() in list() to snapshot against concurrent mutation - Add regression test for unhashable sys.modules entries https://claude.ai/code/session_01PQkqWu11828t7hwzAyR1sZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4660