Don't inject TargetJvmVersion attribute when automatic JVM targeting is disabled#1666
Merged
Don't inject TargetJvmVersion attribute when automatic JVM targeting is disabled#1666
TargetJvmVersion attribute when automatic JVM targeting is disabled#1666Conversation
bc9a7aa to
541b5e4
Compare
This reverts commit 541b5e4.
Goooler
commented
Aug 18, 2025
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Outdated
Show resolved
Hide resolved
bef311d to
0d4eaa0
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the Shadow plugin was incorrectly injecting a TargetJvmVersion attribute with value Int.MAX_VALUE when automatic JVM targeting is disabled in Gradle. The fix moves the target JVM version logic into an afterEvaluate block and adds a check to skip setting the attribute when the value would be Int.MAX_VALUE.
- Move target JVM version attribute configuration to
afterEvaluateblock - Add conditional check to skip setting attribute when value is
Int.MAX_VALUE - Add test coverage for the disabled auto-target JVM scenario
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ShadowJavaPlugin.kt | Refactors target JVM version attribute logic to handle disabled auto-targeting |
| PublishingTest.kt | Adds test case to verify behavior when auto-target JVM is disabled |
| README.md | Updates changelog with the fix description |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Show resolved
Hide resolved
d1949e9 to
02edeed
Compare
02edeed to
f4ed6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1665.