Merged
Conversation
ccecca6 to
cc128ab
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors constant values by moving them from the base ShadowBasePlugin to their respective plugin classes where they are actually used. The changes improve code organization by placing constants closer to their usage points.
- Move
COMPONENT_NAMEfromShadowBasePlugintoShadowJavaPlugin - Move
DISTRIBUTION_NAMEfromShadowBasePlugintoShadowApplicationPlugin - Update import statements and references to use the new constant locations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ShadowJavaPlugin.kt | Adds COMPONENT_NAME constant and updates usage to reference local constant |
| ShadowBasePlugin.kt | Removes COMPONENT_NAME and DISTRIBUTION_NAME constants, adds comprehensive documentation |
| ShadowApplicationPlugin.kt | Adds DISTRIBUTION_NAME constant and updates usage to reference local constant |
| ApplicationPluginTest.kt | Updates import to reference DISTRIBUTION_NAME from ShadowApplicationPlugin |
| README.md | Documents the breaking change in the changelog |
| shadow.api | Updates public API surface to reflect the moved constants |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowBasePlugin.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
ShadowJar#1566