Use BufferedOutputStream when writing the Zip file to improve performance#1580
Merged
Goooler merged 2 commits intoGradleUp:mainfrom Aug 5, 2025
Merged
Conversation
When not using STORED entries use a BufferedOutputStream to avoid lots of small writes to the file system. Testing this with a 300mb jar build I see the total build time going from 40s to 30s. Note that it is not possible to do this with STORED entries as the implementation requires a RandomAccessFile to update the CRC after write.
Contributor
Author
|
I didn't add a changelog entry for this as if the 8.x PR goes in a well then there are no changes compared to the 8.x branch. |
BufferedOutputStream when writing the Zip file to improve performance
Goooler
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not using STORED entries use a BufferedOutputStream to avoid lots of small writes to the file system.
Testing this with a 300mb jar build I see the total build time going from 40s to 30s.
Note that it is not possible to do this with STORED entries as the implementation requires a RandomAccessFile to update the CRC after write.