Expose AbstractDependencyFilter from internal to public#1538
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the AbstractDependencyFilter class from the internal package to the public API, making it available as a nested class within DependencyFilter. The change enables external users to extend the abstract dependency filter functionality.
- Moves
AbstractDependencyFilterfrom internal package to public API as a nested class - Updates existing internal implementations to use the new public location
- Documents the change in the changelog with the new public access path
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DependencyFilter.kt | Adds AbstractDependencyFilter as a public nested class with additional imports |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt | Updates inheritance to use the new public DependencyFilter.AbstractDependencyFilter |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultDependencyFilter.kt | Updates inheritance to use the new public DependencyFilter.AbstractDependencyFilter |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt | Removes the entire internal implementation (file deleted) |
| docs/changes/README.md | Documents the API change in the unreleased section |
| api/shadow.api | Updates the public API signature file to include the new public class |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DependencyFilter.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/DependencyFilter.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs