Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the assemble task depend on the shadowJar task, ensuring that shadow JARs are built when running the standard Gradle assemble lifecycle task.
- Adds a dependency from the
assembletask to theshadowJartask in the plugin configuration - Includes test coverage to verify the dependency relationship
- Updates changelog to document the enhancement
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ShadowJavaPlugin.kt | Adds dependency configuration to make assemble depend on shadowJar task |
| JavaPluginTest.kt | Adds test assertion to verify the assemble task dependency |
| docs/changes/README.md | Documents the new feature in the changelog |
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Outdated
Show resolved
Hide resolved
850159f to
fa8fff3
Compare
fa8fff3 to
08b781a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.