Honor options.release for target JVM attribute#1502
Conversation
options.release for target JVM attribute
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/PublishingTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
Outdated
Show resolved
Hide resolved
src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/PublishingTest.kt
Outdated
Show resolved
Hide resolved
…shadow/PublishingTest.kt
|
Been looking at this in the context of #1540 and I don't think there is a good value to put in If we really wanted to put something here, the best value is probably the minimum of all shadowed jars: Even that feels a bit wrong. If someone is using the fat jar as a compile dependency, only the public API surface needs to be say Java 8. Whether the shadowed libs are Java 11 or 17 doesn't really matter (see also gradle/gradle#33964). But with the current Gradle behaviour, I guess we don't really have a choice if we also want to fix #1416 |
|
I'm afraid we should remove |
👍 This is fine by me. The more I think about this, the more I think the JVM target shouldn't be part of dependency resolution anyways |
Fixes #1501