Allow using file trees of JARs together with the configuration cache#1441
Merged
Goooler merged 4 commits intoGradleUp:mainfrom May 28, 2025
Merged
Allow using file trees of JARs together with the configuration cache#1441Goooler merged 4 commits intoGradleUp:mainfrom
Goooler merged 4 commits intoGradleUp:mainfrom
Conversation
We are adding JARs from a directory that is built by a task to the `ShadowJar` by using `includedDependencies`. That doesn't seem to work when using the configuration cache, since the contents of the directory are evaluated at configuration time, causing them always to be empty. This PR fixes that by doing the actual resolution as late as in the task action, not when the `includedZipTrees` provider is being stored in the configuration cache.
Goooler
approved these changes
May 28, 2025
Contributor
Author
|
@Goooler Thank you for merging this so quickly! Any idea when you are going to do another release that includes the changes? |
Member
|
It will be out in a few hours. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding JARs from a directory that is built by a task to the
ShadowJarby usingincludedDependencies. That doesn't seem to work when using the configuration cache, since the contents of the directory are evaluated at configuration time, causing them always to be empty.This PR fixes that by doing the actual resolution as late as in the task action, not when the
includedZipTreesprovider is being stored in the configuration cache.